Migrating Best Practices topics to Symfony Flex structure #8579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
changed the title
javiereguiluz
approved these changes
Nov 3, 2017
|
|
||
| providers: | ||
| database_users: | ||
| entity: { class: AppBundle:User, property: username } | ||
| entity: { class: App:User, property: username } |
There was a problem hiding this comment.
This could be App\Entity\User ... but it may be better to do that change in all docs in a separate PR.
There was a problem hiding this comment.
Yea, I agree. The namespace is now small enough that this slightly longer format is worth it because it's more clear.
There was a problem hiding this comment.
I've actually just made this change, as this is the only spot in the docs where this appears (there are still many references of AppBundle:, but this is the only one that is App:). As we migrate away from AppBundle, we can also change to not use the shortcut.
weaverryan
added a commit
that referenced
this pull request
Nov 5, 2017
…re (yceruto) This PR was merged into the master branch. Discussion ---------- Migrating Best Practices topics to Symfony Flex structure Pending files for other PR: * configuration.rst * creating-the-project.rst * i18n.rst * templates.rst Commits ------- 176bbdf [Best Practices] More changes of Symfony Flex structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending files for other PR: